Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ascii hostname support #615

Merged
merged 2 commits into from May 15, 2022
Merged

added ascii hostname support #615

merged 2 commits into from May 15, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented May 12, 2022 •
edited by Mzack9999

Description

This PR adds hostname ASCII support.

Notes

Depends on:

Example

echo "ουτοπία.δπθ.gr" | go run . -silent -json

@LuitelSamikshya LuitelSamikshya linked an issue May 12, 2022 that may be closed by this pull request
Non-ascii characters on domain results on no host nor DNS type A output #606
Closed
@LuitelSamikshya LuitelSamikshya added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 12, 2022
@LuitelSamikshya LuitelSamikshya self-assigned this May 12, 2022
Mzack9999
Mzack9999 requested changes May 13, 2022
View reviewed changes
go.sum Show resolved Hide resolved
@Mzack9999 Mzack9999 self-requested a review May 15, 2022 10:58
@Mzack9999 Mzack9999 merged commit a4a946a into dev May 15, 2022
@Mzack9999 Mzack9999 deleted the issue-606-ascii-hostname-support branch May 15, 2022 11:00
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 15, 2022
@ehsandeep
Copy link
Member

follow up ticket - #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-ascii characters on domain results on no host nor DNS type A output
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999