Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support days unit with DuarationVar #120

Merged
merged 2 commits into from
Jun 27, 2023
Merged

support days unit with DuarationVar #120

merged 2 commits into from
Jun 27, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jun 27, 2023 •
edited

#119 Improve DurationVar to support days unit

@RamanaReddy0M RamanaReddy0M self-assigned this Jun 27, 2023
@RamanaReddy0M RamanaReddy0M linked an issue Jun 27, 2023 that may be closed by this pull request
Improve DurationVar to support days unit #119
Closed
@RamanaReddy0M
Copy link
Contributor Author

depends on: projectdiscovery/utils#188

@RamanaReddy0M RamanaReddy0M mentioned this pull request Jun 27, 2023
Merged
Mzack9999
Mzack9999 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

$ go run . -timeout 2d
2023/06/27 14:23:59 48h0m0s

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jun 27, 2023
@Mzack9999 Mzack9999 merged commit 1ab6157 into main Jun 27, 2023
3 checks passed
@Mzack9999 Mzack9999 deleted the issue-119-improve-duration-var branch June 27, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve DurationVar to support days unit
2 participants
@RamanaReddy0M @Mzack9999