Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to convert file size with unit to bytes #112

Merged
merged 4 commits into from
Jun 4, 2023
Merged

Add support to convert file size with unit to bytes #112

merged 4 commits into from
Jun 4, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented May 30, 2023 •
edited

closes #111

@RamanaReddy0M RamanaReddy0M self-assigned this May 30, 2023
@RamanaReddy0M RamanaReddy0M linked an issue May 30, 2023 that may be closed by this pull request
Flag support to convert file size with unit to bytes #111
Closed
Mzack9999
Mzack9999 approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - before merging please cross-check if go 1.20 is also required in go.mod

tarunKoyalwar
tarunKoyalwar approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit cfd5bff into main Jun 4, 2023
3 checks passed
@ehsandeep ehsandeep deleted the issue-111-size-flag-support branch June 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flag support to convert file size with unit to bytes
4 participants
@RamanaReddy0M @ehsandeep @Mzack9999 @tarunKoyalwar