Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioner: Ensure GatewayClass condition generations are updated #4932

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Dec 16, 2022
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner December 16, 2022 20:19
@sunjayBhatia sunjayBhatia requested review from stevesloka and skriss and removed request for a team December 16, 2022 20:19
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #4932 (cdff1bd) into main (a81e387) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4932      +/-   ##
==========================================
+ Coverage   76.47%   76.51%   +0.04%     
==========================================
  Files         140      140              
  Lines       16724    16728       +4     
==========================================
+ Hits        12790    12800      +10     
+ Misses       3684     3679       -5     
+ Partials      250      249       -1     
Impacted Files Coverage Δ
internal/provisioner/controller/gatewayclass.go 62.75% <100.00%> (+3.90%) ⬆️

@sunjayBhatia sunjayBhatia merged commit aac0c6b into projectcontour:main Dec 16, 2022
@sunjayBhatia sunjayBhatia deleted the gw-provisioner-gwclass-status-fix branch December 16, 2022 20:58
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
…rojectcontour#4932)

Related to kubernetes-sigs/gateway-api#1586

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
…rojectcontour#4932)

Related to kubernetes-sigs/gateway-api#1586

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants