-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Examples for Gateway API Support #3664
Conversation
When reviewing, I suggest filtering the commits to separate this PR from #3659. |
Codecov Report
@@ Coverage Diff @@
## main #3664 +/- ##
=======================================
Coverage 75.76% 75.76%
=======================================
Files 107 107
Lines 7327 7327
=======================================
Hits 5551 5551
Misses 1654 1654
Partials 122 122 |
Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days. |
Hey @danehans, this needs a good rebase then can take a look. I think having Gateway examples is a great idea to get folks started. =) |
I think we should try and get this in for 1.16, to help people try out Gateway API functions more easily. I'll add it to milestone + column for now, happy to be overridden here though @xaleeks. |
@youngnick note that examples are not useful until the gateway controller is implemented (targeted for v1.17.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks @danehans
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Adds a script and includes the script in the
generate
make target. This is for supporting a Gateway API install experience similar tokubectl apply -f https://projectcontour.io/quickstart/contour.yaml
.Note that
examples/render/contour-gateway.yaml
was generated frommake generate
.Requires #3659