Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Examples for Gateway API Support #3664

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

danehans
Copy link
Contributor

@danehans danehans commented May 10, 2021

Adds a script and includes the script in the generate make target. This is for supporting a Gateway API install experience similar to kubectl apply -f https://projectcontour.io/quickstart/contour.yaml.

Note that examples/render/contour-gateway.yaml was generated from make generate.

Requires #3659

@danehans danehans requested a review from a team as a code owner May 10, 2021 21:36
@danehans danehans requested review from stevesloka and skriss and removed request for a team May 10, 2021 21:36
@danehans
Copy link
Contributor Author

danehans commented May 10, 2021

When reviewing, I suggest filtering the commits to separate this PR from #3659.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #3664 (1432041) into main (8eaf1e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3664   +/-   ##
=======================================
  Coverage   75.76%   75.76%           
=======================================
  Files         107      107           
  Lines        7327     7327           
=======================================
  Hits         5551     5551           
  Misses       1654     1654           
  Partials      122      122           

@github-actions
Copy link

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021
@stevesloka
Copy link
Member

Hey @danehans, this needs a good rebase then can take a look. I think having Gateway examples is a great idea to get folks started. =)

@youngnick
Copy link
Member

I think we should try and get this in for 1.16, to help people try out Gateway API functions more easily. I'll add it to milestone + column for now, happy to be overridden here though @xaleeks.

@youngnick youngnick added this to the 1.16.0 milestone May 26, 2021
@youngnick youngnick added this to 1.16 release in Contour Project Board May 26, 2021
@youngnick youngnick removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2021
@danehans danehans moved this from 1.16 release to 1.17 release in Contour Project Board May 26, 2021
@danehans danehans modified the milestones: 1.16.0, 1.17.0 May 26, 2021
@danehans
Copy link
Contributor Author

danehans commented Jun 3, 2021

I think we should try and get this in for 1.16, to help people try out Gateway API functions more easily.

@youngnick note that examples are not useful until the gateway controller is implemented (targeted for v1.17.0).

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @danehans

Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
@stevesloka stevesloka merged commit f8adf1d into projectcontour:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Contour Project Board
  
1.17 release (completed)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants