New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s deps for 1.21.0 release #3581
Update k8s deps for 1.21.0 release #3581
Conversation
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
- Coverage 76.70% 76.66% -0.05%
==========================================
Files 100 100
Lines 7066 7066
==========================================
- Hits 5420 5417 -3
- Misses 1530 1533 +3
Partials 116 116
|
Could you also update the support matrix bits as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; if we want to add a main
entry to the compat matrix that's fine with me, otherwise can update when we release 1.15 IMHO.
I'll add an Issue for the 1.15.0 release, since we're not actually testing against 1.21.0 yet (no kind image) I would hold off on changing the matrix |
See also projectcontour/contour#3581 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
I think we should add a 'main` line to the support matrix, that makes keeping everything up to date much easier. In addition, we probably need to remove really old versions. |
|
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
See also projectcontour/contour#3581 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
client-go v1.21.0 appears to be incompatible with controller-runtime v0.8.3:
I get this compilation error when I depend on contour v1.15.0. |
Yep, see kubernetes-sigs/controller-runtime#1473. Contour PR #3510 updates to the latest controller-runtime 0.9.0 beta and we'll update to the GA release as soon as it's out. |
No kind image yet so no update to tested k8s versions yet