Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s deps for 1.21.0 release #3581

Merged
merged 4 commits into from Apr 22, 2021

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Apr 14, 2021

No kind image yet so no update to tested k8s versions yet

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner April 14, 2021 22:14
@sunjayBhatia sunjayBhatia requested review from danehans and youngnick and removed request for a team April 14, 2021 22:14
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #3581 (ef93ceb) into main (3e59de8) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3581      +/-   ##
==========================================
- Coverage   76.70%   76.66%   -0.05%     
==========================================
  Files         100      100              
  Lines        7066     7066              
==========================================
- Hits         5420     5417       -3     
- Misses       1530     1533       +3     
  Partials      116      116              
Impacted Files Coverage Δ
internal/k8s/log.go 63.04% <0.00%> (-6.53%) ⬇️

@stevesloka
Copy link
Member

Could you also update the support matrix bits as well?

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; if we want to add a main entry to the compat matrix that's fine with me, otherwise can update when we release 1.15 IMHO.

@sunjayBhatia
Copy link
Member Author

I'll add an Issue for the 1.15.0 release, since we're not actually testing against 1.21.0 yet (no kind image) I would hold off on changing the matrix

@sunjayBhatia
Copy link
Member Author

#3583

sunjayBhatia added a commit to sunjayBhatia/contour-operator that referenced this pull request Apr 19, 2021
See also projectcontour/contour#3581

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@youngnick
Copy link
Member

I think we should add a 'main` line to the support matrix, that makes keeping everything up to date much easier. In addition, we probably need to remove really old versions.

@sunjayBhatia
Copy link
Member Author

I think we should add a 'main` line to the support matrix, that makes keeping everything up to date much easier. In addition, we probably need to remove really old versions.

#3605

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia merged commit 96d6725 into projectcontour:main Apr 22, 2021
@sunjayBhatia sunjayBhatia deleted the update-k8s-deps branch April 22, 2021 14:53
skriss pushed a commit to projectcontour/contour-operator that referenced this pull request Apr 30, 2021
See also projectcontour/contour#3581

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@jroper
Copy link

jroper commented May 11, 2021

client-go v1.21.0 appears to be incompatible with controller-runtime v0.8.3:

vendor/sigs.k8s.io/controller-runtime/pkg/metrics/client_go_adapter.go:134:3: cannot use &latencyAdapter{...} (type *latencyAdapter) as type metrics.LatencyMetric in field value:
	*latencyAdapter does not implement metrics.LatencyMetric (wrong type for Observe method)
		have Observe(string, url.URL, time.Duration)
		want Observe(context.Context, string, url.URL, time.Duration)
vendor/sigs.k8s.io/controller-runtime/pkg/metrics/client_go_adapter.go:135:3: cannot use &resultAdapter{...} (type *resultAdapter) as type metrics.ResultMetric in field value:
	*resultAdapter does not implement metrics.ResultMetric (wrong type for Increment method)
		have Increment(string, string, string)
		want Increment(context.Context, string, string, string)

I get this compilation error when I depend on contour v1.15.0.

@skriss
Copy link
Member

skriss commented May 11, 2021

client-go v1.21.0 appears to be incompatible with controller-runtime v0.8.3:

vendor/sigs.k8s.io/controller-runtime/pkg/metrics/client_go_adapter.go:134:3: cannot use &latencyAdapter{...} (type *latencyAdapter) as type metrics.LatencyMetric in field value:
	*latencyAdapter does not implement metrics.LatencyMetric (wrong type for Observe method)
		have Observe(string, url.URL, time.Duration)
		want Observe(context.Context, string, url.URL, time.Duration)
vendor/sigs.k8s.io/controller-runtime/pkg/metrics/client_go_adapter.go:135:3: cannot use &resultAdapter{...} (type *resultAdapter) as type metrics.ResultMetric in field value:
	*resultAdapter does not implement metrics.ResultMetric (wrong type for Increment method)
		have Increment(string, string, string)
		want Increment(context.Context, string, string, string)

I get this compilation error when I depend on contour v1.15.0.

Yep, see kubernetes-sigs/controller-runtime#1473. Contour PR #3510 updates to the latest controller-runtime 0.9.0 beta and we'll update to the GA release as soon as it's out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants