Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(W.I.P) Lint import aliases using go-import-alias #3108

Closed
wants to merge 0 commits into from
Closed

(W.I.P) Lint import aliases using go-import-alias #3108

wants to merge 0 commits into from

Conversation

Glyphack
Copy link
Contributor

@Glyphack Glyphack commented Nov 6, 2020 •
edited

FIxes #3021
Used https://github.com/Glyphack/go-import-alias to fix inconsistent import alias names according to CONTRIBUTING.MD
Signed-off-by: Shayegan Hooshyari sh.hooshyari@gmail.com

@Glyphack Glyphack mentioned this pull request Nov 6, 2020
Closed
@Glyphack Glyphack changed the title Lint import aliases using go-import-alias (W.I.P) Lint import aliases using go-import-alias Nov 6, 2020
@stevesloka
Copy link
Member

Hey @Glyphack, sorry but we just removed all the v2 xDS resource api's from Contour and this broken your entire PR. Also I don't see your .golangci-lint config changes. It would be neat to have those on a commit, then on a second commit changes to make sure the imports are proper.

Also we should agree on how the imports are going to be aliased. There are some that are super log in the go-control-plane project.

Thanks!

@Glyphack
Copy link
Contributor Author

Glyphack commented Nov 17, 2020 •
edited

Hey @Glyphack, sorry but we just removed all the v2 xDS resource api's from Contour and this broken your entire PR. Also I don't see your .golangci-lint config changes. It would be neat to have those on a commit, then on a second commit changes to make sure the imports are proper.

I tried creating a custom linter for #3021, since we haven't talk about how to integrate the linter (I guess there are two options: go vet and golangci-lint) I didn't touch the .golangci-lint. I Think I can fix it when we make a decision.

Also we should agree on how the imports are going to be aliased. There are some that are super log in the go-control-plane project.
Yes me and @jpeach talked about a rule and I implemented that. you can see the rule here

Finally I implemented a --fix option for linter and used it on contour main branch to see it's result(this PR), You and others may want to take a look.

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 90 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2020
@jpeach jpeach removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2020
@github-actions
Copy link

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 90 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2020
@jpeach jpeach removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2020
@github-actions
Copy link

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 90 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2020
@Glyphack Glyphack closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom go lint checker
3 participants
@Glyphack @stevesloka @jpeach