Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate the blacklight config #2083

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Encapsulate the blacklight config #2083

merged 2 commits into from
Jan 19, 2022

Commits on Jan 18, 2022

  1. Encapsulate the blacklight config 

    All values set on Blacklight::Engine.config are actually stored
in a class variable on Railtie::Configuration. So these pollute
that namespace.  All other railties are encapsulating their configs
onto a single entry in that scope.  This change makes Blacklight do
likewise.

This probably needs to be a major revision
    @jcoyne @barmintor
    jcoyne authored and barmintor committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    5be0c8e View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. replace use of OpenStruct in Blacklight::Engine with OpenStructWithHa… 

    …shAccess
    @barmintor
    barmintor committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    1db61c3 View commit details
    Browse the repository at this point in the history