Upgrade Codecov action #5024
Merged
Upgrade Codecov action #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoran
force-pushed
the
ci/codecov-update
branch
from
fa78f73
to
11225fe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5024 +/- ##
=====================================
Coverage 94.1% 94.1%
=====================================
Files 377 377
Lines 31243 31243
Branches 3710 3710
=====================================
+ Hits 29399 29403 +4
+ Misses 1174 1170 -4
Partials 670 670 |
This is more direct than relying on option parsing in the Codecov CLI. Unfortunately, Codecov has moved to required a token for uploading. In practice, this breaks coverage uploads from PRs from forks since they do not have access to secrets.
This uses the new Python CLI uploader.
samdoran
force-pushed
the
ci/codecov-update
branch
from
b077803
to
46a5d24
Compare
Removes dumb attempts to run tools that don’t exist and are unnecessary.
samdoran
force-pushed
the
ci/codecov-update
branch
from
46a5d24
to
cba67f5
Compare
samdoran
changed the title
maskarb
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is more direct than relying on option parsing in the Codecov action.
Unfortunately, Codecov has moved to requiring a token for uploads. In practice, this breaks coverage uploads from PRs from forks since they do not have access to secrets even though they have stated this should work for public repos.
We don't have OIDC setup so that's not feasible for us at the moment.
Related to
codecov/feedback#112
codecov/feedback#315
Release Notes