Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit - Update configuration and job versions #4201

Merged
merged 5 commits into from Mar 16, 2023
Merged

pre-commit - Update configuration and job versions #4201

merged 5 commits into from Mar 16, 2023

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Mar 14, 2023 •
edited

Description

  • Update versions of pre-commit jobs
  • Use flake8 from PyCQA
  • Use the latest 22.x version of Black since 23.x made a number of changes (Draft for Black 2023 stable style psf/black#3418). We can move to a new version of black in a separate PR just to keep the changes in this PR smaller.
  • Use types and pass in files for dashboard validation

Testing

  1. Checkout Branch
  2. Run pre-commit run --all-files

@samdoran samdoran added smoke-tests pr_check will build the image and run minimal required smokes smokes-required labels Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited

Codecov Report

Merging #4201 (3384fac) into main (5063a5d) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4201     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.0%     
=======================================
  Files        381     381             
  Lines      31907   31907             
  Branches    3404    3404             
=======================================
- Hits       30059   30058      -1     
- Misses      1208    1209      +1     
  Partials     640     640

@samdoran samdoran changed the title Update pre-commit config pre-commit - Update configuration and job versions Mar 14, 2023
@samdoran samdoran marked this pull request as ready for review March 15, 2023 16:36
@samdoran samdoran requested review from a team as code owners March 15, 2023 16:36
chambridge
chambridge previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@chambridge chambridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samdoran samdoran enabled auto-merge (squash) March 16, 2023 14:14
@samdoran samdoran merged commit 514853b into project-koku:main Mar 16, 2023
6 checks passed
@samdoran samdoran deleted the ci/update-pre-commit branch March 16, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djnakabaale djnakabaale djnakabaale approved these changes

@chambridge chambridge Awaiting requested review from chambridge

Assignees
No one assigned
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Milestone
No milestone
3 participants
@samdoran @djnakabaale @chambridge