Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added allocs profile type #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: added allocs profile type #48

wants to merge 1 commit into from

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Dec 6, 2019

allocs is the unique profile type missed.

Signed-off-by: Gianluca Arbezzano gianarb92@gmail.com

allocs is the unique profile type missed.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@narqo
Copy link
Member

narqo commented Dec 6, 2019

I was under the impression, that "allocs" profile is exactly the same data as "heap" profile, but with "alloc_space" set as the default value of sample_index. I.e. go tool pprof -sample_index=alloc_space heap.pb.gz:

The allocs profile is the same as the heap profile but changes the default pprof display to -alloc_space [..]

Refer to https://github.com/golang/go/blob/0915a19a115ba6bd2a5a95178bfaa076041d270b/src/runtime/pprof/pprof.go#L517-L526

Is there any value in supporing it explicetly in collector?

@gianarb
Copy link
Contributor Author

gianarb commented Dec 7, 2019

I think we are probably not using the right name internally, @goller what do you think? Should we change allocs to alloc_space ?! We also have a space that fails and we do not know how to handle, so maybe there is something we are not doing right in our side collections and naming all the profiles!

@narqo
Copy link
Member

narqo commented Dec 11, 2019

A thing I've noticed recently, which is convincing me, that allocs is somewhere rudimental: from the supported flags in kubectl:

--profile string
  [..] One of (none|cpu|heap|goroutine|threadcreate|block|mutex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants