wip! Initial UI server #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Apr 17, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
| } | ||
|
|
||
| // Sum adds the flat and cum values of a set of nodes. | ||
| func (ns Nodes) Sum() (flat int64, cum int64) { |
There was a problem hiding this comment.
two or more consecutive named function parameters share a type, you can omit the type from all but the last
Suggested change
| func (ns Nodes) Sum() (flat int64, cum int64) { | |
| func (ns Nodes) Sum() (flat, cum int64) { |
| } | ||
|
|
||
| // SortNodes sorts the nodes in a graph based on a specific heuristic. | ||
| func (g *Graph) SortNodes(cum bool, visualMode bool) { |
There was a problem hiding this comment.
two or more consecutive named function parameters share a type, you can omit the type from all but the last
Suggested change
| func (g *Graph) SortNodes(cum bool, visualMode bool) { | |
| func (g *Graph) SortNodes(cum, visualMode bool) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.