This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Switch to safe-eval #774
Closed
Switch to safe-eval #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stathismor
force-pushed
the
switch-to-safe-eval
branch
from
549b497
to
9e46012
Compare
|
@balena-ci rebase |
ghost
force-pushed
the
switch-to-safe-eval
branch
from
9e46012
to
396e322
Compare
|
@stathismor This looks fairly sane to me, though I think it would be worth testing the beta package on a draft PR in the |
static-eval needs an unnecessary object check when writing a callback parameter. It also does not support arrow functions. safe-eval solves both of these issues. Change-type: minor Signed-off-by: Stathis Moraitidis <stathis@balena.io>
LucianBuzzo
force-pushed
the
switch-to-safe-eval
branch
from
396e322
to
919de36
Compare
|
Testing upstream here product-os/jellyfish-worker#1418 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static-evalhas two issues:safe-evalsolves both of these issues. It works a bit differently, it takes the string expression rather than an ast expression. I still kept the esprima, estree packages, as they are useful for identifying the semantics of the expression (what type it is, arguments, etc) which the existing code needs.Change-type: minor
Signed-off-by: Stathis Moraitidis stathis@balena.io