-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logging of first octokit instance is not set #1676
Conversation
f92aff8
to
280ceb3
Compare
Ran into the same issue! below is my suggested patch which will re-utilize the approach to binding the logger already present
|
@kammerjaeger can you update your PR based on @markjm suggestion? |
Thanks, I did not see the helper. I changed it to the proposed code. |
looks like we are ready to go on this? @gr2m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both!
🎉 This PR is included in version 12.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This should fix the logging in the default ocotkit instance from issue #1673