fix: logging of first octokit instance is not set

[kammerjaeger]

This should fix the logging in the default ocotkit instance from issue #1673

[markjm]

Ran into the same issue! below is my suggested patch which will re-utilize the approach to binding the logger already present

diff --git a/src/octokit/get-probot-octokit-with-defaults.ts b/src/octokit/get-probot-octokit-with-defaults.ts
index 16d190b..08373bf 100644
--- a/src/octokit/get-probot-octokit-with-defaults.ts
+++ b/src/octokit/get-probot-octokit-with-defaults.ts
@@ -3,6 +3,7 @@ import { ProbotOctokit } from "./probot-octokit";
 import Redis from "ioredis";
 
 import { getOctokitThrottleOptions } from "./get-octokit-throttle-options";
+import { aliasLog } from "../helpers/alias-log";
 
 import type { Logger } from "pino";
 
@@ -45,6 +46,9 @@ export function getProbotOctokitWithDefaults(options: Options) {
 
   let defaultOptions: any = {
     auth: authOptions,
+    log: options.log.child
+      ? aliasLog(options.log.child({ name: "octokit" }))
+      : options.log,
   };
 
   if (options.baseUrl) {

[gr2m]

@kammerjaeger can you update your PR based on @markjm suggestion?

[kammerjaeger]

Thanks, I did not see the helper. I changed it to the proposed code.
The file get-authenticated-octokit.ts uses the same method that I used before to set the logger. Should that also be changed (in a different PR)?

[markjm]

looks like we are ready to go on this? @gr2m

[gr2m]

Thank you both!

[github-actions]

🎉 This PR is included in version 12.2.4 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀