feat: update esbuild to 0.16 #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/evanw/esbuild/releases/tag/v0.16.0 There is one breaking change with the legalComments default which changed to `none` and I just updated docs and test for this assuming you want to follow esbuild's default (I would).
|
I prefer to follow the default as well, but we'll need to avoid the breaking change to release this as a minor. |
|
Why not bump to 3.0.0? Want to include any other breaking changes in such a version? |
|
Ah, I see #275. Well to me personally, there is nothing critical in esbuild 0.16, so I'm happy to wait a bit longer until this is merged/released. |
|
Any update on when this can be merged in? I would like to test esbuild-loader but am unable to. There is a esbuild defect that was recently fixed and I can't test out esbuild-loader until it is in as a third party library I am using exposes this defect. |
| @@ -338,7 +338,7 @@ Minify JS using equivalent but shorter syntax. | |||
| #### legalComments | |||
| Type: `'none' | 'inline' | 'eof'` | |||
|
|
|||
| Default: `'inline'` | |||
There was a problem hiding this comment.
This was reverted in https://github.com/evanw/esbuild/releases/tag/v0.16.10
This was referenced Jan 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/evanw/esbuild/releases/tag/v0.16.0
There is one breaking change with the legalComments default which changed to
noneand I just updated docs and test for this assuming you want to follow esbuild's default (I would).