Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade esbuild to 0.11.6 #163

Conversation

Adjective-Object
Copy link

Upgrading esbuild to ^0.11.6 to capture the fix for evanw/esbuild#1198

@Adjective-Object
Copy link
Author

@privatenumber I think there may be an issue with the PR build. These runs are failing with missing type errors, which I don't think would be triggered by an esbuild upgrade.

...
Error: src/loader.ts(1,16): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
Error: src/loader.ts(2,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
Error: src/loader.ts(3,52): error TS2307: Cannot find module 'esbuild' or its corresponding type declarations.
Error: src/loader.ts(4,26): error TS2307: Cannot find module 'loader-utils' or its corresponding type declarations.
Error: src/loader.ts(5,21): error TS2307: Cannot find module 'webpack' or its corresponding type declarations.
...

@privatenumber
Copy link
Owner

Closing this in favor of #164 which updates to the latest 0.11.18


The reason why tests failed is because the lock file was not updated. The tests weren't updated so that would've failed too.

And FYI, the evanw/esbuild#1198 fix was released in v0.11.16 so this update wouldn't include that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants