Update session-builder.ts #78
Conversation
fix
create_session error SignalProtocolAddress { _name: 'xxx', _deviceId: 1 } TypeError: Cannot read properties of null (reading 'version')
at Function.deserialize (/root/xxx/node_modules/@privacyresearch/libsignal-protocol-typescript/lib/session-record.js:56:18)
at SessionBuilder.<anonymous> (/root/xxx/node_modules/@privacyresearch/libsignal-protocol-typescript/lib/session-builder.js:64:57)
at Generator.next (<anonymous>)
at fulfilled (/root/xxx/node_modules/@privacyresearch/libsignal-protocol-typescript/lib/session-builder.js:24:58)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
There was a problem hiding this comment.
This looks reasonable modulo my small comment, but I want to understand the need for this change better.
The StorageType interface declares loadSession to return Promise<string | undefined>. Presumably your storage service is returning a string that is actually null. Is there a semantic difference between null and undefined return values in your storage implementation? (e.g. null means "I know about this session but it is gone" and undefined means "this session never existed") If so, where do you use this distinction?
If not, is it possible to ensure that your storage always returns undefined instead of null?
If we make this change and move the responsibility to distinguish null/undefined to the SDK then I think we need a bigger review of the code. (But could merge this as a start.)
| @@ -55,7 +55,7 @@ export class SessionBuilder { | |||
| const address = this.remoteAddress.toString() | |||
| const serialized = await this.storage.loadSession(address) | |||
| let record: SessionRecord | |||
| if (serialized !== undefined) { | |||
| if (serialized !== undefined && serialized != null) { | |||
There was a problem hiding this comment.
I'd prefer checking serialized !== null to avoid the implicit conversions. (Since null == undefined is true we could just say serialized != undefined here and it would eliminate null, but the !== makes things more clear IMO.)
fix
create_session error SignalProtocolAddress { _name: 'xxx', _deviceId: 1 } TypeError: Cannot read properties of null (reading 'version') at Function.deserialize (/root/xxx/node_modules/@privacyresearch/libsignal-protocol-typescript/lib/session-record.js:56:18) at SessionBuilder.<anonymous> (/root/xxx/node_modules/@privacyresearch/libsignal-protocol-typescript/lib/session-builder.js:64:57) at Generator.next (<anonymous>) at fulfilled (/root/xxx/node_modules/@privacyresearch/libsignal-protocol-typescript/lib/session-builder.js:24:58) at processTicksAndRejections (node:internal/process/task_queues:96:5)