-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show forum topics on homepage #2562
Conversation
8af846b
to
bdb2da4
Compare
✅ Your preview is ready!
|
7aa467c
to
969602f
Compare
969602f
to
d4131b7
Compare
The new sections display weirdly on Mullvad Browser and Tor Browser (Safer and Standard security levels). Otherwise, they look great on other browsers! (Tested in Firefox+Arkenfox and Vanadium, appears as displayed in the initial post in this PR) Edit: NoScript isn't the issue, tested with a fresh Firefox profile with just NoScript installed and changed NoScript settings to reflect those in MB and TB |
Funny, I honestly don't know why it did work in other browsers actually. Good catch, should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind the idea of having some recent forum topics on the homepage, but I'm not too keen on how this looks in particular. It's very text heavy... I'd also be a tad worried if someone spammed the forum and accordingly was able to get onto the main site.
Perhaps a sidebar of some sort would be better. I like the idea but I'm not sure if this is the best way of doing it.
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
32201b1
to
26f3300
Compare
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Our homepage is of course our most trafficked page, but despite this it hasn't really changed at all in years. This would make it a bit more dynamic for new visitors.
Adds two different sections to the page:
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.