Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show forum topics on homepage #2562

Merged
merged 1 commit into from
May 19, 2024
Merged

Show forum topics on homepage #2562

merged 1 commit into from
May 19, 2024

Conversation

jonaharagon
Copy link
Member

Our homepage is of course our most trafficked page, but despite this it hasn't really changed at all in years. This would make it a bit more dynamic for new visitors.

Adds two different sections to the page:

7VKBqZB15kKMKpiV

QSe3QuClYOWB6QeX

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

jonaharagon added a commit that referenced this pull request May 1, 2024
@jonaharagon jonaharagon added c:enhancements new features or other enhancements to the website itself fix:seo search engine optimization! javascript Pull requests that update Javascript code labels May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Your preview is ready!

Name Link
🔨 Latest commit 32201b1
😎 Preview https://2562--glowing-salamander-8d7127.netlify.app/

@jonaharagon jonaharagon added the ci:build i18n Enable translated builds on a PR label May 1, 2024
jonaharagon added a commit that referenced this pull request May 1, 2024
jonaharagon added a commit that referenced this pull request May 1, 2024
@redoomed1
Copy link
Contributor

redoomed1 commented May 1, 2024

The new sections display weirdly on Mullvad Browser and Tor Browser (Safer and Standard security levels).

topics-week_mb-safer

new-topics_tb-standard

Otherwise, they look great on other browsers! (Tested in Firefox+Arkenfox and Vanadium, appears as displayed in the initial post in this PR)


Edit: NoScript isn't the issue, tested with a fresh Firefox profile with just NoScript installed and changed NoScript settings to reflect those in MB and TB

@jonaharagon
Copy link
Member Author

Funny, I honestly don't know why it did work in other browsers actually. Good catch, should be fixed.

@redoomed1
Copy link
Contributor

should be fixed.

Can confirm it's fixed!
topics-fixed_mullvad-browser

Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the idea of having some recent forum topics on the homepage, but I'm not too keen on how this looks in particular. It's very text heavy... I'd also be a tad worried if someone spammed the forum and accordingly was able to get onto the main site.

Perhaps a sidebar of some sort would be better. I like the idea but I'm not sure if this is the best way of doing it.

Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 26f3300 into main May 19, 2024
13 checks passed
@dngray dngray deleted the homepage-forum-topics branch May 19, 2024 03:01
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-05-22/18443/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself ci:build i18n Enable translated builds on a PR fix:seo search engine optimization! javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants