Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cromite to Mobile Browsers #2381

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

austinhuang0131
Copy link

@austinhuang0131 austinhuang0131 commented Jan 30, 2024

Changes proposed in this PR:

  • add Cromite back. Logo (svg) is my own reproduction of the official logo (which is in png).
  • I have disclosed any relevant conflicts of interest in my post. (none other than being a user of it)
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work. (Some are referenced from b3ceb64 but it's y'all so I don't think there is a copyright issue)
  • I agree to the Community Code of Conduct.

Criteria:

Must support automatic updates.

yes

Must receive engine updates in 0-1 days from upstream release.

0-1 days is a bit too strict for a one-person project. DivestOS claims it's "within a week," my personal observation is usually 1 day, occasionally up to 3. Maybe we can ask the maintainer for this

Any changes required to make the browser more privacy-respecting should not negatively impact user experience.

doesn't appear to

Android browsers must use the Chromium engine.

yes

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 6591c7f
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65f06efff629c000083b76fd
😎 Deploy Preview https://deploy-preview-2381.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 71 (🔴 down 5 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dngray
Copy link
Member

dngray commented Jan 30, 2024

Discussion thread for this https://discuss.privacyguides.net/t/cromite-bromite-fork/13274

@freddy-m freddy-m added the c:browsers browsers, add-ons, and related topics label Jan 30, 2024
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must receive engine updates in 0-1 days from upstream release.

0-1 days is a bit too strict for a one-person project. DivestOS claims it's "within a week," my personal observation is usually 1 day, occasionally up to 3. Maybe we can ask the maintainer for this

we also have to change the criteria at the bottom of this page if we add a recommendation which doesn't match them.

@austinhuang0131
Copy link
Author

or should we ask the dev about their release schedule? since referring to the chromium release blog is not the best idea since not every version is an exact match

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/cromite-bromite-fork/13274/47

Copy link
Contributor

@rollsicecream rollsicecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Seems like it doesn't uses HTML admonitions that should now be used on the website. Of course, there's no rush for this but we will need to convert this page later on to the new admonitions.

Also, speaking of this PR, seems like the "homepage button" for Cromite isn't here! There's cromite.org available but it redirects to the GitHub page. So, what we could do here is : Display the "homepage" button that contains cromite.org or the GH page. Something like this should be added :

[:octicons-home-16: Homepage](https://cromite.org){ .md-button .md-button--primary }

@uazo
Copy link

uazo commented Feb 8, 2024

Sorry to intrude.
first of all, thank you for taking cromite into consideration, that pleases me.

but, if it is possible, i would ask you to be patient with your publication, until issue uazo/cromite#710 is resolved.
to date I have some doubts about the legality of the distribution of my executables, regarding the support of aac and h264, due to the lack of a licence that it will not be possible for me to purchase it due to the high costs
Although I am not aware of how many installations my browser has, under 100,000 I can be comfortable, but a higher spread that might happen after your change. could bring me legal problems.

thank you for your consideration.
I remain at your disposal if you have any questions.

another thing, and please excuse me, I don't think those recommendations are good as default for cromite, but I don't want to sound cheeky and I might be wrong after all.

@uazo
Copy link

uazo commented Mar 12, 2024

until issue uazo/cromite#710 is resolved.

thanks for your patience, i'll let you know that i've solved at least for windows and android. linux is a bit more complex and for now it's a todo.

@uazo
Copy link

uazo commented Mar 12, 2024

if you want I can tell you what I think the defaults should be, actually I plan to include them when I try to put cromite on the google store, which I will only do after I have written the privacy policy (which are not easy to write because, it is true, unlike other browsers, I do not send myself any data, ever, but the browser collects a lot locally).

@austinhuang0131
Copy link
Author

the recommendations were copied from the ones used for Bromite which appears to be written some time (2+ years) ago

personally i don't really agree with them either but eh

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/revisiting-sandboxing-firefox-on-android/17840/33

@uazo
Copy link

uazo commented Apr 14, 2024

Cromite won’t 7 be added until its maintainer allows us to.

I apologise, really! that point has been closed, the issue is only open for the linux version. I'm sorry I didn't tell you @jonaharagon

@jonaharagon
Copy link
Member

@uazo I wasn't sure if you wanted to wait until that was resolved for Linux as well, or if you didn't want us to share it until it was on mainstream platforms like Google Play.

But if you're happy with it then I'm happy with it 👍

Signed-off-by: Austin Huang <im@austinhuang.me>
@uazo
Copy link

uazo commented Apr 14, 2024

I wasn't sure if you wanted to wait until that was resolved for Linux as well,

unfortunately I still don't know how to solve it, that's the problem. the only way is to force the user to recompile ffmpeg, but that's a solution I don't like.

or if you didn't want us to share it until it was on mainstream platforms like Google Play.

no, really, I forgot, sorry.

@austinhuang0131
Copy link
Author

i still think the recommended measures should be reviewed (I just copied whatever's written for Bromite before), particularly regarding whether one should always use incognito

Copy link

github-actions bot commented Apr 14, 2024

Your preview is ready!

Name Link
🔨 Latest commit 71d2900
😎 Preview https://2381--glowing-salamander-8d7127.netlify.app/

Signed-off-by: Austin Huang <im@austinhuang.me>
@uazo
Copy link

uazo commented Apr 14, 2024

i still think the recommended measures should be reviewed

I agree, is one of the points I would like to address.

particularly regarding whether one should always use incognito

do you mean the always incognito?
has its merits, but I don't think it is suitable for the average user, for whom the 'open external links in incognito' option is more suitable.
I think in particular that the default automatic wipe of data at start-up should be by default, and that it is essential to add the option to clean tabs links at startup, which is not there. regarding the latter i would like to include some other opensource project in cromite as a java library... 4 years from bromite were not enough :) but there is time, slowly I will do it all!


![Cromite logo](assets/img/browsers/cromite.svg){ align=right }

**Cromite** is a Chromium-based browser with privacy and security enhancements, built-in ad blocking, and some fingerprinting randomization. It is the continuation of Bromite.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and some fingerprinting randomization.

some because I never detailed them, correct?
do you think it is right for me to do so, i.e. to detail what has been implemented and what I think is missing?
do you happen to have a list of those implemented in brave as a comparison?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it is right for me to do so, i.e. to detail what has been implemented and what I think is missing?

I would like that then I would directly link to it.

do you happen to have a list of those implemented in brave as a comparison?

There are various blog articles that I think one would have to go through. This however might be more relevant as it discusses what is randomized and what is blocked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think has to do with testing at https://privacytests.org/android - where it seems to cover similar things to Brave but less than Mull. Not that I think Cromite should go as far as Mull does necessarily, to be clear. There are tradeoffs here, and I don't think Cromite intends to go as far as Firefox RFP?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://privacytests.org/android

ah I didn't even know @arthuredelstein added cromite!

where it seems to cover similar things to Brave but less than Mull

let's talk about it if you want. the results of each test should be interpreted.
But I don't think cromite is necessarily better than others: what cromite lacks is testing (and spread :) and I am okay with the fact that there are excellent sites like that and the duck duck test site because I use them to check regressions.
too bad there is no site that compare the same browser on different devices, not so much on functionality, but on how it looks to the Web sites.
creepjs, my reference website, has something similar, but it is hidden very well in the code.

Not that I think Cromite should go as far as Mull does necessarily, to be clear.

Unfortunately, I don't know Mull so I can't answer that.

I don't think Cromite intends to go as far as Firefox RFP?

I don't know that one either.
I can tell you that my goal is to make all devices as similar as possible, as Tor does.

@I-I-IT I-I-IT mentioned this pull request Jun 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:browsers browsers, add-ons, and related topics
Projects
Status: Unreviewed
Development

Successfully merging this pull request may close these issues.

None yet

7 participants