New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flag for language selector icon #2062
Conversation
jonaharagon
commented
Mar 1, 2023
•
edited
edited
✅ Deploy Preview for privacyguides ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The hook replaces on the fly the mkdocs-material site-packages raw header.html partial https://github.com/squidfunk/mkdocs-material/blob/master/material/partials/header.html. |
ea5c2ff
to
67f08d2
Compare
@kamilkrzyskow yeah I was testing without that override and it still didn't work, but it seems to be related to #2063 in that case, which is yet another entirely unrelated bug :) Anyways I can just do this a different way with jinja formatting it turns out, so I'll just go with that for now. Ideally |
67f08d2
to
39f484a
Compare
Your solution with the additional I mentioned your partial override, because the commit didn't remove it. I tested the hook locally and after removing your custom partial it works fine 😮💨 (of course this is the old Public version without the privacy plugin). |
39f484a
to
e336699
Compare
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |