Remove icon from external source #1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `:trophy:` icon is received from MaxCDN. The icon is not necessary too, so I removed it.
|
🎊 PR Preview b1f842d has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1115.surge.sh 🕐 Build time: 86.649s
🤖 By surge-preview |
|
Yikes, kind of annoyed that any of these are external actually, since the other icons are not. Investigating |
|
I would rather wait and see if squidfunk/mkdocs-material#3851 can be resolved, since we use more emojis than just this one. |
|
You're right. It totally slipped my mind that this was a bug in the Privacy plugin. |
|
Closing this. Best case the Privacy plugin is updated. Worst case scenario I'd rather put together a PR that manually adds all the emojis we use the same way as our other custom icons, instead of this. Which would be annoying, but I'd rather not go without emojis :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon is not necessary and it is loaded from an external source. So, I removed it.