-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sha256 circuit #756
base: main
Are you sure you want to change the base?
sha256 circuit #756
Conversation
Ooh, nice! I would love to see this adapted to implement the |
Hey @Brechtpd I'm adding the challenge API to all three keccak implementations we currently have in #925. I hope this does not collide with that (Otherwise, I'll code it with features or an option or whatever). Please, ping me to review it! Since reviewed the last 3 I guess I'd be a bit faster! Thanks for working on this!!!! 😄 |
I don't think there will be any conflict with the keccak implementations, and will update the code confirming to #925 if it's decided this implementation will be used for the sha256 precompile (or if useful regardless of that to e.g. compare between different implementations). :) |
That's nice!! Thanks a lot!! I'd also consider the 4 options and stick to only 1 or 2. Otherwise we need to mantain a lot more code. WDYT? |
What do you mean 4 options? I think for sha256 there's only like 2 I guess (this one or the halo2 one). Or are you talking about keccak? |
Indeed mate.. My brain classified SHA256 and keccak as the same thing xD Apologies, we already discussed the 3 different keccak implementations privately. 🙏 |
* fix: several fixes | wip debuging * remove unnecessary part * fix: assert equal for op output and success * fix: G2 coeffs * chore: remove info log
Adds a sha256 circuit with the same lookup interface as the keccak circuit.