Feat/#1752 fix witness generation - json exportor #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructedLeaf in witness generator used now only for wrong row
github-actions
bot
added
the
crate-geth-utils
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
from
400dca8
to
799a02d
Compare
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
from
08778eb
to
394211a
Compare
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
from
47ff445
to
ba8df43
Compare
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
from
ba8df43
to
e5c7559
Compare
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
from
f8e266f
to
9b0eb3f
Compare
KimiWu123
changed the title
github-actions
bot
added
the
crate-zkevm-circuits
…aling-explorations/zkevm-circuits into extension-into-branch
…fix-witness-generation-json-export
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
2 times, most recently
from
d641299
to
4fff94d
Compare
KimiWu123
force-pushed
the
feat/#1752-fix-witness-generation-json-export
branch
from
4fff94d
to
3e90dda
Compare
|
Hi @miha-stopar, I merged #1756, but only .go files, and now everything works, all the tests were passed! It' ready for review . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closed #1752
Issue Link
#1752
Type of change
Contents
GenerateWitnessto export json for stack trie.isTxProofflag inequipLeafWithModExtensionNodeand `addBranchAndPlaceholder' to avoid touching the exising logic of the state trie.GetProof(): before this fix, if any hashed nodes in the proof, other non-hashed nodes will not append to the proof. This causes the output proofs are incorrect.StackProoffor exporting json files.