Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use .mjs module exports #111

Merged
merged 1 commit into from
Jan 14, 2022
Merged

fix: use .mjs module exports #111

merged 1 commit into from
Jan 14, 2022

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Jan 14, 2022

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR updates the module exports to use .mjs rather than .js. This fixes an issue with Next.js 12 when deploying to Vercel (note that the problem only occurs in production). See #108 for more details.

.mjs originally was not used because it broken CRA 4. CRA 5 includes updates that resolves this issue (most likely the change to Webpack 5).

Related issues:

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@angeloashmore angeloashmore mentioned this pull request Jan 14, 2022
7 tasks
@angeloashmore angeloashmore merged commit 23f04fb into master Jan 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #111 (c485fc1) into master (a2f2c23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          16       16           
  Lines         268      268           
  Branches       59       59           
=======================================
  Hits          247      247           
  Misses          5        5           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f2c23...c485fc1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants