Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tokio_rustls #306

Merged
merged 2 commits into from
Aug 21, 2023
Merged

update tokio_rustls #306

merged 2 commits into from
Aug 21, 2023

Conversation

Liyixin95
Copy link
Contributor

update tokio_rustls from 0.23.x to 0.24.x

tomhoule
tomhoule approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tomhoule
Copy link
Contributor

Hmm, there are errors in the tests that look TLS-related. I don't have time to investigate right now unfortunately, but I think you should have access to the CI output.

@Liyixin95
Copy link
Contributor Author

Hmm, there are errors in the tests that look TLS-related. I don't have time to investigate right now unfortunately, but I think you should have access to the CI output.

The vendored-openssl is also failed. Both errors are "certificate has expired". And I find your server.crt has expired at 2023-07-16. So, maybe you need to update your certificate?

@Liyixin95
Copy link
Contributor Author

I can regenerate certificates according to the README in docker/certs, if you don't mind.

@tomhoule
Copy link
Contributor

Aaah I see, yes if you can that would be awesome.

@Liyixin95
Copy link
Contributor Author

Aaah I see, yes if you can that would be awesome.

The cert has been updated.

@janpio janpio requested a review from tomhoule August 21, 2023 11:24
@tomhoule
Copy link
Contributor

Thank you! Tests are green, let's merge :)

@tomhoule tomhoule merged commit 8f66a69 into prisma:main Aug 21, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule Awaiting requested review from tomhoule

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Liyixin95 @tomhoule