Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow query on columns with space in name #296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Geo-W
Copy link

@Geo-W Geo-W commented May 28, 2023

As sql server allows empty space in column name, make it adaptable to columns with space in its name.

@tomhoule
Copy link
Contributor

This looks good. Do you think this would be straightforward to check in a test?

@Geo-W
Copy link
Author

Geo-W commented May 31, 2023

This looks good. Do you think this would be straightforward to check in a test?

Sure! Thank you very much~

@descawed
Copy link
Contributor

descawed commented Oct 8, 2023

I was bitten by this issue today when attempting to do a bulk insert to a table having columns with spaces in the name. Is this just waiting on a test to be merged? I can take a crack at it if @Geo-W isn't able to. The code should probably also be updated to handle the case where the column name contains the ] character, which would need to be escaped by doubling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants