Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rust to v1.78.0 #4861

Merged
merged 1 commit into from May 10, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 10, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
rust minor 1.77.0 -> 1.78.0

Release Notes

rust-lang/rust (rust)

v1.78.0

Compare Source

==========================

Language

Compiler

Target changes:

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Misc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

v1.77.2

Compare Source

===========================

v1.77.1

Compare Source

===========================


Configuration

📅 Schedule: Branch creation - "before 7am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 10, 2024 01:53
@renovate renovate bot requested review from jkomyno and removed request for a team May 10, 2024 01:53
Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.152MiB 2.152MiB 0.000B
Postgres (gzip) 845.855KiB 845.856KiB -1.000B
Mysql 2.123MiB 2.123MiB 0.000B
Mysql (gzip) 832.880KiB 832.881KiB -1.000B
Sqlite 2.016MiB 2.016MiB 0.000B
Sqlite (gzip) 793.209KiB 793.209KiB -1.000B

Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #4861 will degrade performances by 13.51%

Comparing renovate/rust-toolchain-update (61152f6) with main (482e329)

Summary

❌ 3 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main renovate/rust-toolchain-update Change
validate (large) 310 ms 358.4 ms -13.51%
validate (medium) 67.7 ms 77.9 ms -13.06%
validate (small) 9.5 ms 11 ms -13.12%

Copy link
Contributor

✅ WASM query-engine performance won't change substantially (1.001x)

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.20.2 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p999
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - ~50K)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     295 ms/iter       (294 ms … 296 ms)    296 ms    296 ms    296 ms
Web Assembly: Latest       380 ms/iter       (378 ms … 383 ms)    381 ms    383 ms    383 ms
Web Assembly: Current      381 ms/iter       (380 ms … 383 ms)    383 ms    383 ms    383 ms
Node API: Current          199 ms/iter       (196 ms … 200 ms)    200 ms    200 ms    200 ms

summary for movies.findMany() (all - ~50K)
  Web Assembly: Current
   1.92x slower than Node API: Current
   1.29x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  12'079 µs/iter (11'815 µs … 14'699 µs) 12'019 µs 14'699 µs 14'699 µs
Web Assembly: Latest    15'593 µs/iter (15'199 µs … 18'128 µs) 15'460 µs 18'128 µs 18'128 µs
Web Assembly: Current   15'446 µs/iter (15'134 µs … 17'449 µs) 15'362 µs 17'449 µs 17'449 µs
Node API: Current        8'057 µs/iter   (7'903 µs … 8'426 µs)  8'130 µs  8'426 µs  8'426 µs

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   1.92x slower than Node API: Current
   1.28x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'900 µs/iter   (1'793 µs … 3'094 µs)  1'883 µs  2'857 µs  3'094 µs
Web Assembly: Latest     2'411 µs/iter   (2'336 µs … 3'142 µs)  2'410 µs  2'937 µs  3'142 µs
Web Assembly: Current    2'420 µs/iter   (2'349 µs … 3'055 µs)  2'423 µs  2'866 µs  3'055 µs
Node API: Current        1'421 µs/iter   (1'334 µs … 1'839 µs)  1'431 µs  1'685 µs  1'839 µs

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   1.7x slower than Node API: Current
   1.27x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     556 ms/iter       (551 ms … 571 ms)    556 ms    571 ms    571 ms
Web Assembly: Latest       760 ms/iter       (755 ms … 767 ms)    763 ms    767 ms    767 ms
Web Assembly: Current      762 ms/iter       (756 ms … 770 ms)    770 ms    770 ms    770 ms
Node API: Current          482 ms/iter       (473 ms … 496 ms)    487 ms    496 ms    496 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.58x slower than Node API: Current
   1.37x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  77'461 µs/iter (76'729 µs … 78'184 µs) 78'062 µs 78'184 µs 78'184 µs
Web Assembly: Latest       107 ms/iter       (106 ms … 108 ms)    108 ms    108 ms    108 ms
Web Assembly: Current      108 ms/iter       (107 ms … 110 ms)    109 ms    110 ms    110 ms
Node API: Current       63'183 µs/iter (62'292 µs … 64'047 µs) 64'039 µs 64'047 µs 64'047 µs

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.71x slower than Node API: Current
   1.4x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     984 ms/iter     (977 ms … 1'005 ms)    985 ms  1'005 ms  1'005 ms
Web Assembly: Latest     1'268 ms/iter   (1'261 ms … 1'284 ms)  1'276 ms  1'284 ms  1'284 ms
Web Assembly: Current    1'274 ms/iter   (1'265 ms … 1'292 ms)  1'289 ms  1'292 ms  1'292 ms
Node API: Current          901 ms/iter       (857 ms … 940 ms)    935 ms    940 ms    940 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.41x slower than Node API: Current
   1.3x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     140 ms/iter       (138 ms … 142 ms)    141 ms    142 ms    142 ms
Web Assembly: Latest       176 ms/iter       (175 ms … 177 ms)    177 ms    177 ms    177 ms
Web Assembly: Current      179 ms/iter       (177 ms … 182 ms)    181 ms    182 ms    182 ms
Node API: Current          109 ms/iter       (108 ms … 111 ms)    110 ms    111 ms    111 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.64x slower than Node API: Current
   1.28x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     884 µs/iter     (823 µs … 1'557 µs)    877 µs  1'473 µs  1'557 µs
Web Assembly: Latest     1'211 µs/iter   (1'136 µs … 1'895 µs)  1'209 µs  1'809 µs  1'895 µs
Web Assembly: Current    1'230 µs/iter   (1'154 µs … 1'945 µs)  1'225 µs  1'835 µs  1'945 µs
Node API: Current          768 µs/iter     (700 µs … 1'182 µs)    789 µs    831 µs  1'182 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.6x slower than Node API: Current
   1.39x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     883 µs/iter     (851 µs … 1'528 µs)    887 µs  1'188 µs  1'528 µs
Web Assembly: Latest     1'260 µs/iter   (1'146 µs … 1'893 µs)  1'214 µs  1'871 µs  1'893 µs
Web Assembly: Current    1'204 µs/iter   (1'154 µs … 1'698 µs)  1'215 µs  1'410 µs  1'698 µs
Node API: Current          809 µs/iter     (723 µs … 1'367 µs)    805 µs  1'184 µs  1'367 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.49x slower than Node API: Current
   1.36x slower than Web Assembly: Baseline
   1.05x faster than Web Assembly: Latest

After changes in 61152f6

@laplab laplab added this to the 5.14.0 milestone May 10, 2024
@laplab laplab merged commit e162a52 into main May 10, 2024
207 of 208 checks passed
@laplab laplab deleted the renovate/rust-toolchain-update branch May 10, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant