New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qe): Add comparison for uuid <-> uuid for batching #4857

Draft

Druue wants to merge 1 commit into main from fix/batch-uuid

+54 −0

Contributor

Druue commented May 8, 2024

allows e.g. "xxxxxxxx-xxxx...." == "xxxxxxxxxxxx..."

closes prisma/prisma#13552


          Update handler to be able to compare uuids of different formats.

be7fba3

e.g. "xxxxxxxx-xxxx...." == "xxxxxxxxxxxx..."

Druue added this to the 5.14.0 milestone

Druue requested a review from a team as a code owner

May 8, 2024 11:36

Druue requested review from jkomyno and removed request for a team

May 8, 2024 11:36

Druue marked this pull request as draft

May 8, 2024 12:10

SevInf requested changes

View reviewed changes

Contributor

SevInf left a comment

Hey, I am gonna block this for now.
Currently. implementation does coercion for every string that looks like UUID which is incorrect - not every UUID-looking string is a UUID and we should not just declare it to be equal to a different string.

Druue requested review from SevInf and Weakky and removed request for jkomyno

May 8, 2024 12:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment