Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update driver adapters directory (patch) #4851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 4, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) 20.12.7 -> 20.12.12 age adoption passing confidence
tsx 4.7.2 -> 4.7.3 age adoption passing confidence

Release Notes

privatenumber/tsx (tsx)

v4.7.3

Compare Source

Bug Fixes
  • support TS resolution in JS files when allowJs is set (#​535) (081853e)

This release is also available on:


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 4, 2024 02:35
@renovate renovate bot requested review from laplab and removed request for a team May 4, 2024 02:35
Copy link
Contributor

github-actions bot commented May 4, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.153MiB 2.153MiB 0.000B
Postgres (gzip) 846.059KiB 846.060KiB -1.000B
Mysql 2.119MiB 2.119MiB 0.000B
Mysql (gzip) 831.749KiB 831.748KiB 1.000B
Sqlite 2.015MiB 2.015MiB 0.000B
Sqlite (gzip) 793.079KiB 793.079KiB 0.000B

Copy link

codspeed-hq bot commented May 4, 2024

CodSpeed Performance Report

Merging #4851 will not alter performance

Comparing renovate/patch-driver-adapters-directory (6ebe010) with main (793f7fb)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented May 4, 2024

✅ WASM query-engine performance won't change substantially (1.000x)

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.20.2 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p999
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - ~50K)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     371 ms/iter       (367 ms … 376 ms)    374 ms    376 ms    376 ms
Web Assembly: Latest       451 ms/iter       (447 ms … 457 ms)    453 ms    457 ms    457 ms
Web Assembly: Current      454 ms/iter       (450 ms … 460 ms)    459 ms    460 ms    460 ms
Node API: Current          196 ms/iter       (193 ms … 199 ms)    198 ms    199 ms    199 ms

summary for movies.findMany() (all - ~50K)
  Web Assembly: Current
   2.32x slower than Node API: Current
   1.22x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  14'926 µs/iter (14'618 µs … 16'788 µs) 14'968 µs 16'788 µs 16'788 µs
Web Assembly: Latest    18'293 µs/iter (18'117 µs … 18'748 µs) 18'369 µs 18'748 µs 18'748 µs
Web Assembly: Current   18'400 µs/iter (18'165 µs … 20'279 µs) 18'353 µs 20'279 µs 20'279 µs
Node API: Current        8'150 µs/iter  (7'829 µs … 11'234 µs)  8'082 µs 11'234 µs 11'234 µs

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   2.26x slower than Node API: Current
   1.23x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   2'295 µs/iter   (2'194 µs … 3'303 µs)  2'287 µs  3'052 µs  3'303 µs
Web Assembly: Latest     2'854 µs/iter   (2'760 µs … 3'535 µs)  2'844 µs  3'403 µs  3'535 µs
Web Assembly: Current    2'851 µs/iter   (2'766 µs … 3'655 µs)  2'845 µs  3'400 µs  3'655 µs
Node API: Current        1'376 µs/iter   (1'285 µs … 1'781 µs)  1'390 µs  1'637 µs  1'781 µs

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   2.07x slower than Node API: Current
   1.24x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     570 ms/iter       (565 ms … 578 ms)    572 ms    578 ms    578 ms
Web Assembly: Latest       781 ms/iter       (777 ms … 785 ms)    784 ms    785 ms    785 ms
Web Assembly: Current      778 ms/iter       (773 ms … 786 ms)    781 ms    786 ms    786 ms
Node API: Current          473 ms/iter       (453 ms … 492 ms)    480 ms    492 ms    492 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.64x slower than Node API: Current
   1.37x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  79'521 µs/iter (78'507 µs … 80'924 µs) 80'794 µs 80'924 µs 80'924 µs
Web Assembly: Latest       109 ms/iter       (109 ms … 110 ms)    109 ms    110 ms    110 ms
Web Assembly: Current      111 ms/iter       (110 ms … 112 ms)    112 ms    112 ms    112 ms
Node API: Current       61'476 µs/iter (60'439 µs … 62'861 µs) 62'731 µs 62'861 µs 62'861 µs

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.8x slower than Node API: Current
   1.4x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'010 ms/iter   (1'007 ms … 1'014 ms)  1'013 ms  1'014 ms  1'014 ms
Web Assembly: Latest     1'316 ms/iter   (1'300 ms … 1'332 ms)  1'331 ms  1'332 ms  1'332 ms
Web Assembly: Current    1'316 ms/iter   (1'303 ms … 1'331 ms)  1'327 ms  1'331 ms  1'331 ms
Node API: Current          861 ms/iter       (837 ms … 892 ms)    878 ms    892 ms    892 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.53x slower than Node API: Current
   1.3x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     148 ms/iter       (148 ms … 149 ms)    149 ms    149 ms    149 ms
Web Assembly: Latest       186 ms/iter       (181 ms … 189 ms)    187 ms    189 ms    189 ms
Web Assembly: Current      182 ms/iter       (181 ms … 185 ms)    182 ms    185 ms    185 ms
Node API: Current          111 ms/iter       (109 ms … 114 ms)    114 ms    114 ms    114 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.63x slower than Node API: Current
   1.23x slower than Web Assembly: Baseline
   1.02x faster than Web Assembly: Latest

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'079 µs/iter     (990 µs … 2'110 µs)  1'062 µs  1'824 µs  2'110 µs
Web Assembly: Latest     1'406 µs/iter   (1'304 µs … 2'191 µs)  1'392 µs  2'076 µs  2'191 µs
Web Assembly: Current    1'397 µs/iter   (1'320 µs … 2'334 µs)  1'399 µs  1'825 µs  2'334 µs
Node API: Current          778 µs/iter     (703 µs … 1'488 µs)    798 µs  1'040 µs  1'488 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.8x slower than Node API: Current
   1.3x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'045 µs/iter     (982 µs … 1'879 µs)  1'040 µs  1'689 µs  1'879 µs
Web Assembly: Latest     1'427 µs/iter   (1'303 µs … 2'175 µs)  1'391 µs  2'153 µs  2'175 µs
Web Assembly: Current    1'408 µs/iter   (1'323 µs … 2'234 µs)  1'405 µs  2'204 µs  2'234 µs
Node API: Current          788 µs/iter     (714 µs … 1'279 µs)    807 µs    939 µs  1'279 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.79x slower than Node API: Current
   1.35x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

After changes in 6ebe010

@renovate renovate bot force-pushed the renovate/patch-driver-adapters-directory branch from f1859af to f43497e Compare May 11, 2024 00:46
@renovate renovate bot changed the title chore(deps): update dependency tsx to v4.7.3 chore(deps): update driver adapters directory (patch) May 11, 2024
@renovate renovate bot force-pushed the renovate/patch-driver-adapters-directory branch from f43497e to c8b4eb9 Compare May 18, 2024 04:54
@renovate renovate bot force-pushed the renovate/patch-driver-adapters-directory branch from c8b4eb9 to 6ebe010 Compare May 25, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants