feat(psl): Validation error when shadowDatabaseUrl is identical to url or directUrl

[pranayat]

Hi there !

This PR closes prisma/prisma#16628

[codspeed-hq]

CodSpeed Performance Report

Merging #4831 will not alter performance

_{Comparing pranayat:feat/shadow-same-as-direct (22344d2) with main (612a7f7)}

Summary

✅ 11 untouched benchmarks

[Druue]

Hey @pranayat! thanks for the PR :)
I took a look and I'm only getting this validation error to appear when I have all three url properties defined.

Error appears on both url and directUrl here when they're both defined

But does not appear at all here when only url and shadowDatabaseUrl are defined - A datasource without url leads to other validation errors :)

[pranayat]

@Druue Ah good catch! I've spotted the issue in my code, shall fix it :)

[pranayat]

I've pushed a commit which I hopes passes the CI checks. Ever since I synced my branch with upstream two weeks ago, local builds make my system go out of disk space, so I'm no longer able to run tests locally.

[pranayat]

@Druue Can review now :)

[Druue]

Looks good to me, just one final nit 😅

[Druue]

✨ 🎉

[janpio]

Late to the party (so feel free to ignore!), but how about adding ... to avoid data loss. to the end of both error messages to give users some explanation why as well?

[pranayat]

Late to the party (so feel free to ignore!), but how about adding ... to avoid data loss. to the end of both error messages to give users some explanation why as well?

I'll most certainly not ignore this 😄, could save users a google search.

[Druue]

Awesome! Thank you so much! :D ❤️

[pranayat]

Awesome! Thank you so much! :D ❤️

Thank you for the great review 😄