Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(schema-engine): allow SQLite migration to be D1-compatible #4808

Merged
merged 3 commits into from May 5, 2024
Merged

test(schema-engine): allow SQLite migration to be D1-compatible #4808

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13bead5
test(schema-engine): allow SQLite migration to be D1-compatible
jkomyno Apr 3, 2024
3a5827e
test(schema-engine): fix failures in "migrations::foreign_keys::chang…
jkomyno Apr 3, 2024
61ede41
Merge branch 'main' into feat/d1-compatible-sqlite-migration
jkomyno Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion schema-engine/connectors/sql-schema-connector/src/sql_renderer/sqlite_renderer.rs
View file
Open in desktop
Expand Up @@ -185,6 +185,7 @@ impl SqlRenderer for SqliteFlavour {
fn render_redefine_tables(&self, tables: &[RedefineTable], schemas: MigrationPair<&SqlSchema>) -> Vec<String> {
// Based on 'Making Other Kinds Of Table Schema Changes' from https://www.sqlite.org/lang_altertable.html
let mut result = vec!["PRAGMA foreign_keys=OFF".to_string()];
let mut foreign_key_checks = vec![];

for redefine_table in tables {
let tables = schemas.walk(redefine_table.table_ids);
Expand All @@ -208,9 +209,17 @@ impl SqlRenderer for SqliteFlavour {
for index in tables.next.indexes().filter(|idx| !idx.is_primary_key()) {
result.push(self.render_create_index(index));
}

// Collect foreign key checks for any renamed tables.
// These must be executed immediately before `PRAGMA foreign_keys=ON`.
foreign_key_checks.push(format!(
r#"PRAGMA foreign_key_check("{new_name}")"#,
new_name = tables.next.name()
));
}

result.push("PRAGMA foreign_key_check".to_string());
result.extend(foreign_key_checks);

result.push("PRAGMA foreign_keys=ON".to_string());

result
Expand Down