nix: add wasm tooling to the default dev shell #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
requested review from
miguelff and
Druue
and removed request for
a team
aqrln
commented
Nov 23, 2023
| @@ -8,6 +8,8 @@ | |||
| in rec | |||
| { | |||
| pkgs = import flakeInputs.nixpkgs { inherit system overlays; }; | |||
| rustToolchain = pkgs.rust-bin.stable.latest; | |||
| rustToolchain = pkgs.rust-bin.stable.latest.default.override { | |||
| targets = ["wasm32-unknown-unknown"]; | |||
There was a problem hiding this comment.
We can also put this into rust-toolchain.toml for rustup to automatically handle this for everyone not using nix, and change this to pkgs.rust-bin.fromRustupToolchainFile ../rust-toolchain.toml.
There was a problem hiding this comment.
Yes, please (non blocking)
There was a problem hiding this comment.
will do in a follow-up PR, need to merge it now to avoid a merge conflict in another one
CodSpeed Performance ReportMerging #4495 will not alter performanceComparing Summary
|
miguelff
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.