Fix crdb sql-introspection tests and pin docker image versions #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelff
requested review from
jkomyno and
Druue
and removed request for
a team
|
Putting this on hold, there are 3 new tests failing having to do with sequences. I will keep working on this task. |
CodSpeed Performance ReportMerging #4490 will improve performances by 5.78%Comparing Summary
Benchmarks breakdown
|
|
@miguelff conflict in docker sha now |
|
This is not a priority after tests becoming stable again by pinning the previous versions of CRDB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close https://github.com/prisma/team-orm/issues/618