qe: repair OVERWRITE_DATASOURCES param in binary CLI #3203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened:
parse_dml()
, it does not throw away the configuration part of the schema.psl::parse_configuration()
on the same schema again throughOpts::configuration()
. That saved work and code.How this commit fixes it:
Opts::schema()
now takes the sameignore_env_var_errors
param asOpts::configuration()
and overrides datasource urls in the same way.It may be worth revisiting this whole mechanism later, but this should fix prisma/prisma integration for now.