qe: fix prisma/13097 #3186
Merged
qe: fix prisma/13097 #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
qe/prisma-13097
branch
from
bca9a35
to
e2a7282
Compare
This appears to be a simple business logic error. In this PR, we test that array field returned from groupBy queries are properly retrieved from their rows, both when selected and when aggregated. closes prisma/prisma#13097 Internal spec document: https://www.notion.so/prismaio/groupBy-array-columns-a1179e49a56c42c8b1f1bd69f617f26a
tomhoule
force-pushed
the
qe/prisma-13097
branch
from
e2a7282
to
ae9a5a5
Compare
|
Added the test at prisma/prisma#15217 |
garrensmith
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a simple business logic error.
In this PR, we test that array field returned from groupBy queries are
properly retrieved from their rows, both when selected and when
aggregated.
closes prisma/prisma#13097
Internal spec document: https://www.notion.so/prismaio/groupBy-array-columns-a1179e49a56c42c8b1f1bd69f617f26a