fix: prevent deletion of 'raster_columns' and 'raster_overviews' PostGIS columns in prisma migrate #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GIS columns in prisma migrate
|
(flaky Mac OS compile check, restarted that on Buildkite) |
tomhoule
reviewed
Sep 16, 2022
There was a problem hiding this comment.
Looks good! Let's just document where the names came from so we can track in which conditions these tables appear, etc. The list is growing and the risk of false positives is getting larger, we might want to enforce that postgis tables are in a separate schema and then ignore diffing that schema, we could do that with the multi-schema awareness. Or even ignore them conditionally based on the extensions declared in the datasource with the extensions proposal we are implementing. I'll open an issue.
...nnectors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs
Show resolved
Hide resolved
|
Here's the issue: prisma/prisma#15363 |
jkomyno
commented
Sep 16, 2022
...nnectors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs
Show resolved
Hide resolved
tomhoule
approved these changes
Sep 16, 2022
jkomyno
commented
Sep 16, 2022
...nnectors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of this comment based on this previous PR.
Closes prisma/prisma#15361 and prisma/prisma#15363.