Merge pull request #3198 from prisma/fix/migrate-prevent-deleting-pos…

…tgis-columns fix: prevent deletion of 'raster_columns' and 'raster_overviews' PostGIS columns in prisma migrate
prisma · Sep 17, 2022 · fb56bfe · fb56bfe
2 parents 4124c5c + 32bdca5
commit fb56bfe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/...ctors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs b/...ctors/sql-migration-connector/src/sql_schema_differ/sql_schema_differ_flavour/postgres.rs
@@ -22,6 +22,9 @@ static POSTGIS_TABLES_OR_VIEWS: Lazy<RegexSet> = Lazy::new(|| {
         "(?i)^spatial_ref_sys$",
         "(?i)^geometry_columns$",
         "(?i)^geography_columns$",
+        // See §11.2 in: https://postgis.net/docs/using_raster_dataman.html
+        "(?i)^raster_columns$",
+        "(?i)^raster_overviews$",
     ])
     .unwrap()
 });

diff --git a/migration-engine/migration-engine-tests/tests/migrations/postgres.rs b/migration-engine/migration-engine-tests/tests/migrations/postgres.rs
@@ -71,6 +71,8 @@ fn existing_postgis_tables_must_not_be_migrated(api: TestApi) {
         /* The capitalized Geometry is intentional here, because we want the matching to be case-insensitive. */
         CREATE TABLE IF NOT EXISTS "Geometry_columns" ( id SERIAL PRIMARY KEY );
         CREATE TABLE IF NOT EXISTS "geography_columns" ( id SERIAL PRIMARY KEY );
+        CREATE TABLE IF NOT EXISTS "raster_columns" ( id SERIAL PRIMARY KEY );
+        CREATE TABLE IF NOT EXISTS "raster_overviews" ( id SERIAL PRIMARY KEY );
     "#;
 
     api.raw_cmd(create_tables);
@@ -79,7 +81,9 @@ fn existing_postgis_tables_must_not_be_migrated(api: TestApi) {
     api.assert_schema()
         .assert_has_table("spatial_ref_sys")
         .assert_has_table("Geometry_columns")
-        .assert_has_table("geography_columns");
+        .assert_has_table("geography_columns")
+        .assert_has_table("raster_columns")
+        .assert_has_table("raster_overviews");
 }
 
 // Reference for the views created by PostGIS: https://postgis.net/docs/manual-1.4/ch04.html#id418599