Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Banner accessibility guidance #2829

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented May 9, 2024

What are you trying to accomplish?

This PR makes the existing Banner accessibility guidance more concise.

There was also recent confusion around why a live region announcement when a hidden Banner with a live region attribute was unhidden. This PR makes clear that hidden Banners are also subject to not work well with live regions.

List the issues that this change affects.

Fixes: https://github.com/github/accessibility/issues/6320

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: ff93de5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khiga8 khiga8 force-pushed the kh-make-guidance-more-concise branch from 2b5d781 to ff93de5 Compare May 9, 2024 19:47
@khiga8 khiga8 added the skip changeset Pull requests that don't change the library output label May 9, 2024
@khiga8 khiga8 marked this pull request as ready for review May 9, 2024 19:49
@khiga8 khiga8 requested a review from a team as a code owner May 9, 2024 19:49
@khiga8 khiga8 requested a review from keithamus May 9, 2024 19:49
@jonrohan jonrohan merged commit 8eab6c7 into main May 13, 2024
34 of 35 checks passed
@jonrohan jonrohan deleted the kh-make-guidance-more-concise branch May 13, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants