Only report immutable class selectors, add ignoreSelectors option #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
commented
Sep 18, 2019
| const config = { | ||
| plugins: [require.resolve('../plugins/no-override')], | ||
| rules: { | ||
| 'primer/no-override': [true, {bundles: ['base']}] |
There was a problem hiding this comment.
This test tells the primer/no-override rule only to match selectors in the "base" bundle, which is where we normalize element styles, including hr.
shawnbot
commented
Sep 18, 2019
shawnbot
commented
Sep 18, 2019
| @@ -4,6 +4,7 @@ const {requirePrimerFile} = require('../src/primer') | |||
| const ruleName = 'primer/no-override' | |||
| const CLASS_PATTERN = /(\.[-\w]+)/ | |||
| const CLASS_PATTERN_ALL = new RegExp(CLASS_PATTERN, 'g') | |||
| const CLASS_PATTERN_ONLY = /^\.[-\w]+(:{1,2}[-\w]+)?$/ | |||
There was a problem hiding this comment.
Aaaand here's the ugly part: a regular expression that matches any class selector with an optional pseudo-class.
shawnbot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing this in github/github, I noticed that there were a bunch of false positives for non-class selectors like
ul,li, etc. This is an update to the work in #37 that:"in <selector>"bit at the end).ignoreSelectorsrule option that allows you to ignore selectors containing one or more strings, matching one or more regular expressions, or satisfying a function.