Add openOnFocus prop to AutocompleteInput
#4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c1557c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I wonder if we'd want up/down arrow keys to open the menu if this prop is used. For example, if you set |
size-limit report 📦
|
I think this makes sense as behavior! Let me implement that tomorrow! |
Co-authored-by: Kendall Gassner <kendallgassner@github.com>
JoyceZhu
requested review from
kendallgassner and
TylerJDev
and removed request for
TylerJDev
kendallgassner
approved these changes
May 13, 2024
Merged
khiga8
pushed a commit
that referenced
this pull request
May 31, 2024
* Add `openOnFocus` prop to `AutocompleteInput` Towards github/accessibility-audits#7437 * Add changeset * Fix JSON formatting * Allow up and down to open menu if not already open * update hook * Update packages/react/src/Autocomplete/AutocompleteInput.tsx Co-authored-by: Kendall Gassner <kendallgassner@github.com> --------- Co-authored-by: Kendall Gassner <kendallgassner@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks github/accessibility-audits#7437
The audit issue notes that when an
AutocompleteInputis the first field in a form with errors (and thus when it needs to be auto-focused after submission to help the user discover and address errors), the autocomplete menu popping up automatically on focus 1) causes NVDA+Firefox to miss reading out an associated error message/FormControl.Validationeven when linked viaaria-describedbyand 2) visually obscures the error message, which makes discovering what went wrong harder.Offering a prop to optionally disable the menu appearing on focus improves these two users experiences; the menu will still render when the user types in the autocomplete's input field.
Changelog
New
openOnFocusprop which defaults totrue(current behavior) toAutocompleteInputChanged
Removed
Rollout strategy
Testing & Reviewing
Merge checklist