Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental Label component #4535

Closed
wants to merge 5 commits into from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Apr 25, 2024

Note

This is a part of our weekly mob programming session 👀

Token -> Label
AvatarToken -> Label w/ leading visual prop
IssueLabelToken -> IssueLabel

Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: 14c9aa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 25, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.37 KB (0%)
packages/react/dist/browser.umd.js 88.68 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4535 April 25, 2024 17:09 Inactive
@lukasoppermann
Copy link
Contributor

Hey, I am a bit concern with the name Label. A label is different from what we want. The correct name would be IssueLabel, can we rename it?

@langermank
Copy link
Contributor

Notes for next pair session:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants