Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental SelectPanel: use radio visual for single selection #4534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Experimental SelectPanel: use radio visual for single selection #4534

wants to merge 2 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Apr 25, 2024 •
edited

Changelog

Before After
single selection with checkmark single selection with radio

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests): No instances of selectionVariant=single on production

@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@siddharthkp siddharthkp self-assigned this Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.08 KB (+0.12% 🔺)
packages/react/dist/browser.umd.js 88.37 KB (+0.1% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4534 April 25, 2024 16:02 Inactive
@siddharthkp siddharthkp added the no-breaking-changes: confirmed Tested this change doesn't break any existing instances in applications using changed components label Apr 25, 2024
@siddharthkp siddharthkp changed the title Experimental SelectPanel: use radio button for single selection Experimental SelectPanel: use radio visual for single selection Apr 25, 2024
@siddharthkp siddharthkp added patch release bug fixes, docs, housekeeping component: SelectPanel labels Apr 25, 2024
@siddharthkp siddharthkp marked this pull request as ready for review April 25, 2024 16:17
@siddharthkp siddharthkp requested a review from a team as a code owner April 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@pksjce pksjce Awaiting requested review from pksjce pksjce is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@siddharthkp siddharthkp

Labels
component: SelectPanel no-breaking-changes: confirmed Tested this change doesn't break any existing instances in applications using changed components patch release bug fixes, docs, housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddharthkp @joshblack