Make sure Link is underlined when inline={true}
#4531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7088054 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dipree
changed the title
inline={true}
size-limit report 📦
|
joshblack
requested changes
Apr 24, 2024
Comment on lines
34
to
+35
| text-decoration: ${props => (props.underline ? 'underline' : undefined)}; | ||
| text-decoration: ${props => (props.inline ? 'underline' : undefined)}; |
There was a problem hiding this comment.
I think we'll need one line otherwise the inline value will always override, maybe something like:
Suggested change
| text-decoration: ${props => (props.underline ? 'underline' : undefined)}; | |
| text-decoration: ${props => (props.inline ? 'underline' : undefined)}; | |
| text-decoration: ${props => (props.underline || props.inline ? 'underline' : undefined)}; |
There was a problem hiding this comment.
Thank you, it's not a problem but definitely better style. Remaining problem is the data attribute if set to false affecting the underline: true. We might want to deprecate underline first 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/github/primer/issues/2099
Currently, the
inlineproperty only works in combination with thedata-a11y-link-underlinesattribute. However, the link should always be underlined ifinlineis set to true and no attribute is provided.Changelog
Changed
If
inlineis set totrue, the Link will be underlined even if not using thedata-a11y-link-underlinesattribute.Rollout strategy
Testing & Reviewing
Merge checklist