Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Overlay: Attach escape handler to overlay container (#1824)" #1856

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

siddharthkp
Copy link
Member

#1824 fixed a bug in memex (#1802) but a new one (#1854)

This is a breaking change. Reverting this change to bring back after fixing the issues, which could possibly require breaking changes in the applications. Tracking here: #1854

@siddharthkp siddharthkp requested review from a team, colebemis and rezrah February 10, 2022 17:47
@siddharthkp siddharthkp self-assigned this Feb 10, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2022

🦋 Changeset detected

Latest commit: 35b11b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 62.61 KB (-0.1% 🔽)
dist/browser.umd.js 63 KB (-0.1% 🔽)

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @siddharthkp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants