Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing contrast checks #949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding missing contrast checks #949

wants to merge 1 commit into from

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented May 3, 2024 •
edited

Summary

Adding control color contrast checks

Warning

A11y test needs to be run manually to see if it passes as this PR does not change any tokens.
https://github.com/primer/primitives/actions/runs/8939783026

@lukasoppermann lukasoppermann requested review from a team as code owners May 3, 2024 12:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: 6df12c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview (Storybook) May 3, 2024 12:44 Inactive
@lukasoppermann lukasoppermann added the skip changeset Apply to PRs that should not result in a version bump. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank

Assignees
No one assigned
Labels
skip changeset Apply to PRs that should not result in a version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukasoppermann @jonrohan