-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding swift colorset action #490
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4c1ef22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Variables changedNo variables changed |
🟢 No design token changes found |
* Run build script | ||
* ----------------------------------- */ | ||
buildDesignTokens({ | ||
buildPath: 'tokens-v3-private/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to add this path to the files config so it's included in the npm package? https://github.com/primer/primitives/blob/iOS-colorsets/package.json#L5-L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. At the moment it is in demo mode and not meant to be available. I am still trying to figure out in here: https://github.com/github/primer/issues/1698 how to best distribute it for iOS. You do not by any chance have iOS experience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not by any chance have iOS experience?
sorry, have practically zero experience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. 🤣
This PR adds an action that creates colorsets for swift from the provided color tokens.