Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding swift colorset action #490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding swift colorset action #490

wants to merge 2 commits into from

Conversation

lukasoppermann
Copy link
Contributor

This PR adds an action that creates colorsets for swift from the provided color tokens.

@lukasoppermann lukasoppermann requested a review from a team as a code owner February 10, 2023 08:31
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: 4c1ef22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023

Variables changed
No variables changed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023

🟢 No design token changes found

@lukasoppermann lukasoppermann temporarily deployed to github-pages February 10, 2023 08:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 10, 2023 08:38 Inactive
* Run build script
* ----------------------------------- */
buildDesignTokens({
buildPath: 'tokens-v3-private/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add this path to the files config so it's included in the npm package? https://github.com/primer/primitives/blob/iOS-colorsets/package.json#L5-L10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. At the moment it is in demo mode and not meant to be available. I am still trying to figure out in here: https://github.com/github/primer/issues/1698 how to best distribute it for iOS. You do not by any chance have iOS experience?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not by any chance have iOS experience?

sorry, have practically zero experience

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. 🤣

@github-actions github-actions bot temporarily deployed to storybook-preview February 14, 2023 00:10 Inactive
@siddharthkp siddharthkp removed their request for review July 26, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants