Add picosvg to optimization step

[eliperkins]

Related to:

• remove fill-rule="even-odd" #876
• [Bug] Some icons render incorrectly or throw warnings when used in iOS, macOS xcasset bundles #866

This adds in picosvg to the "Optimize SVGs" workflow, removing fill-rule="evenodd" from all SVGs.

Since picosvg is meant to work on a single file at a time, I used a bash loop to iterate through all files in icons before writing them back out, in-place.

cc @gavinmn @colebemis

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5e4813a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[colebemis]

This is great. Thank you, @eliperkins!

Looks like you need to update the snapshots. This should do the trick:

npm i
npm run build
cd lib/octicons_react
npm i --legacy-peer-deps
npm run test -- -u

[eliperkins]

@colebemis @gavinmn any advice on getting the Deploy / Preview / Deploy step working? I'm assuming it's because I've contributed from a fork.

Run actions/deploy-pages@v1
[10](https://github.com/primer/octicons/actions/runs/3690040482/jobs/6246685568#step:2:11)
Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable

Are we okay merging this without a preview deploy?

[eliperkins]

Closing this in favor of #883 , since that'll use better permission checks on Actions for deployments.