Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The SVGs in /build/svg/ don't have the octicon classes attached #997

Open
fregante opened this issue Dec 12, 2023 · 1 comment
Open
Labels

Comments

@fregante
Copy link
Contributor

Describe the bug

The classes:

Expected behavior

Could you include the octicon octicon-something classes in the built SVGs?

I only need this in @primer/octicons, but the issue also appears in @primer/octicons-react (however I don't understand the point of the built SVG files in that package since they're not allowed by the exports map)

Context

I want to import the raw SVGs in my extensions

@fregante
Copy link
Contributor Author

So this is because the icons are plainly copied from the ./icons folder, which understandably doesn't have any extraneous attributes.

This issue doesn't affect me anymore though, I'm using https://github.com/fregante/octicons-plain-react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant