feat: add no-deprecated-imports rule #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5bd3190 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
cc @broccolinisoup @pksjce @siddharthkp would love your thoughts here 👀 |
There was a problem hiding this comment.
Thanks for raising this PR! I like the idea! 🙌🏻
It is also good timing that we just chatted with @siddharthkp last week about adding another rule for the title prop that we will deprecate in favor of ActionList.GroupHeading. I like that it is one rule that can take care of all deprecation warning. I have two questions:
- Are you thinking this as a complementary practise to TS
@deprecatednotice? - Can we extend on this rule to create prop/function/component specific rules? Mainly because if we want deprecation rules that have
a11yprefixes because they for accessibility improvements (to be able to add to the scorecards). Or maybe we can duplicate this rule and create another one witha11yprefix and we can use this rule for a11y specific deprecations? Or I am very curious to hear if you or anyone else have another idea to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept for a rule that will help to avoid using deprecated imports from
@primer/react. This could be used to encourage use of non-deprecated code and can help with the migration of code from an older format to a newer one.Would love to hear what folks think about this approach, currently it's being used for a proposal for our v37.x release around
SSRProvideranduseSSRSafeIdusage.